Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Window.Focus() and BringToFront() consistent across platforms #2646

Merged
merged 2 commits into from Apr 24, 2024

Conversation

cwensley
Copy link
Member

@cwensley cwensley commented Apr 23, 2024

  • Mac: Fix Window.Focus()
  • Mac: Don't fire GotFocus/LostFocus on a Window twice when the first responder is the window itself.
  • Focus() should bring to front and make active (set keyboard focus)
  • BringToFront() should not make window active, just change z-order
  • Focus() is the same as BringToFront() when CanFocus = false

- Fix Window.Focus() on macOS
- Focus() should bring to front and make active (set keyboard focus)
- BringToFront() should not make window active, just change z-order
- Focus() is the same as BringToFront() when CanFocus = false
@cwensley cwensley added the bug label Apr 23, 2024
@cwensley cwensley added this to the 2.8.4 milestone Apr 23, 2024
@cwensley cwensley merged commit 8819ec1 into picoe:develop Apr 24, 2024
3 checks passed
@cwensley cwensley deleted the curtis/window-focus-and-bringtofront branch April 24, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant