Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make space copyable #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make space copyable #3

wants to merge 1 commit into from

Conversation

oleggator
Copy link
Contributor

I see no reasons for space to be non-copyable.

@volt0
Copy link
Contributor

volt0 commented Jul 26, 2021

Copy - is for implicit copying. It is an edge measure and is only allowed if the type semantics so require. For example primitive types. Space is not a primitive type, or anything like that. Accordingly, it does not need Copy.

Clone might be useful. There really are no technical obstacles. But then you need not to point-wise add where the need arises, but to comb the entire code base for adding Clone. At least it can be added to Index, possibly somewhere else.

Could you describe your case? It might be possible to resolve your issue without merging this pull request.

@volt0 volt0 mentioned this pull request Jul 26, 2021
Open
@volt0 volt0 self-requested a review July 26, 2021 10:44
shunkovvs pushed a commit that referenced this pull request Feb 19, 2024
@Kasen
Merge pull request #3 from picodata/add-support-of-vshard-groups
481a956 
Add ability to specify in values.yml vshard Group for each role
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@volt0 volt0 Awaiting requested review from volt0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oleggator @volt0