Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build.gradle compileSdkVersion to 34 #2120

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

arrrrny
Copy link

@arrrrny arrrrny commented May 1, 2024

Below dependencies require compileSdkVersion 34 and when the parent project compileSdkVersion is 33 this package is not built, it is misleading for projects that have not upgraded to 34

implementation 'androidx.webkit:webkit:1.8.0'
implementation 'androidx.browser:browser:1.6.0'

Connection with issue(s)

Resolve issue #???

Connected to #???

Testing and Review Notes

Screenshots or Videos

To Do

  • double check the original issue to confirm it is fully satisfied
  • add testing notes and screenshots in PR description to help guide reviewers
  • request the "UX" team perform a design review (if/when applicable)

Below dependencies require compileSdkVersion 34 and when the parent project compileSdkVersion is 33 this package is not built, it is misleading for projects that have not upgraded to 34

 implementation 'androidx.webkit:webkit:1.8.0'
 implementation 'androidx.browser:browser:1.6.0'
@Augustinekan
Copy link

Hello, I keep getting this error when I point to this pull request:Could not find a file named "pubspec.yaml" in https://github.com/pichillilorenzo/flutter_inappwebview.git 7b4e11e6772b0ea02d01aebae3ce2d0a5d7ea369.
What could be causing this issue?

@komaxx
Copy link

komaxx commented May 16, 2024

Hello, I keep getting this error when I point to this pull request:Could not find a file named "pubspec.yaml" in https://github.com/pichillilorenzo/flutter_inappwebview.git 7b4e11e6772b0ea02d01aebae3ce2d0a5d7ea369. What could be causing this issue?

The trouble there is that there's no pubspec.yaml file in the root directory of the repository. Thus, you need to supply a path in addition to the commit reference.

Try this:

dependency_overrides:
  # TODO: Recheck once flutter_inappwebview version >6.0.0 is released
  flutter_inappwebview:
    git:
      url: https://github.com/pichillilorenzo/flutter_inappwebview
      path: flutter_inappwebview
      ref: 7b4e11e6772b0ea02d01aebae3ce2d0a5d7ea369

The same way, you can just override the federated platform plugin that needs the change:

dependency_overrides:
  # TODO: Recheck once flutter_inappwebview version >6.0.0 is released
  flutter_inappwebview_android:
    git:
      url: https://github.com/pichillilorenzo/flutter_inappwebview
      path: flutter_inappwebview_android
      ref: 7b4e11e6772b0ea02d01aebae3ce2d0a5d7ea369

This will then only override the Android plugin with the changes from the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants