Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web] fix web callbacks #2058

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

p-mazhnik
Copy link

@p-mazhnik p-mazhnik commented Mar 8, 2024

Fixes #2026, fixes #2045, fixes #2046

Related to flutter/flutter#143922

@asarkar101
Copy link

@p-mazhnik you didn't assign any reviewer.

@p-mazhnik
Copy link
Author

@asarkar101 I am not a maintainer of this repository, therefore it is not possible to request reviews.

@sanalkv
Copy link

sanalkv commented Mar 21, 2024

@pichillilorenzo Please kindly review this.

@sanalkv
Copy link

sanalkv commented Apr 2, 2024

@p-mazhnik looks like the owner is not active :( @pichillilorenzo

@GelistirmeKF
Copy link

@pichillilorenzo This issue is so important for us, please consider this commit.

@david98pp
Copy link

@p-mazhnik How can I test your branch or import your branch to my project with your solution?

@p-mazhnik
Copy link
Author

@david98pp you can add dependency override

dependency_overrides:
  flutter_inappwebview_web:
    git:
      url: git@github.com:p-mazhnik/flutter_inappwebview.git
      path: flutter_inappwebview_web
      ref: 7cac4c3c0ce50302cb9144901f425d00e4bf4870 
      # or ref: web-fix

@david98pp
Copy link

david98pp commented Apr 26, 2024

@p-mazhnik thanks for your help, the method onUpdateVisitedHistory is still not working for me, do I have to do anything extra? or any solution?

@david98pp
Copy link

@p-mazhnik the error is: DOMException: Failed to read a named property 'history' from 'Window': Blocked a frame with origin "http://localhost:58988" from accessing a cross-origin frame.
at HTMLIFrameElement. (http://localhost:58988/assets/packages/flutter_inappwebview_web/assets/web/web_support.js

@asarkar101
Copy link

@p-mazhnik the error is: DOMException: Failed to read a named property 'history' from 'Window': Blocked a frame with origin "http://localhost:58988" from accessing a cross-origin frame. at HTMLIFrameElement. (http://localhost:58988/assets/packages/flutter_inappwebview_web/assets/web/web_support.js

same issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants