New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InAppWebViewManager: fix nullptr in InAppWebViewManager.dispose #2031

Open

Murmurl912 wants to merge 1 commit into pichillilorenzo:master from Murmurl912:fix_keepalive_dispose_android_nullptr

Murmurl912 commented Feb 20, 2024 •

edited

Connection with issue(s)

Resolve issue #2025

Connected to #2025

Testing and Review Notes

Use the demo project to test if this works: https://github.com/Murmurl912/inappwebview_dispose_keepalive_nullptr

Screenshots or Videos

To Do

double check the original issue to confirm it is fully satisfied
add testing notes and screenshots in PR description to help guide reviewers
request the "UX" team perform a design review (if/when applicable)

probot-autolabeler bot added the android label


          InAppWebViewManager: fix nullptr in InAppWebViewManager.dispose

1d4b8f3

Murmurl912 force-pushed the fix_keepalive_dispose_android_nullptr branch from 55f9ec0 to 1d4b8f3 Compare

February 20, 2024 03:22

HammadBukhari commented Feb 27, 2024

I've tested this locally and it fixes the Android null pointer exception when disposing webview that is using keep alive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment