Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/ajax #2023

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

EArminjon
Copy link
Contributor

@EArminjon EArminjon commented Feb 15, 2024

Connection with issue(s)

Some Ajax calls are intercepted and broken.

I got an issue on iOS where some ajax call made by iframes were not working. On Android these iframes are well working.
Hard to share something because it didn't produce any logs...

After comparing your iOS and Android implementation I saw a difference in code. I copy and paste so the same logic done in Android into iOS and magic, it's works !

The logic that I took from Android for iOS :

var w = (window.top == null || window.top === window) ? window : window.top;
w.FLAG_VARIABLE_FOR_SHOULD_INTERCEPT_AJAX_REQUEST_JS_SOURCE

Testing and Review Notes

Screenshots or Videos

To Do

  • double check the original issue to confirm it is fully satisfied
  • add testing notes and screenshots in PR description to help guide reviewers
  • request the "UX" team perform a design review (if/when applicable)

@EArminjon
Copy link
Contributor Author

EArminjon commented Mar 14, 2024

@pichillilorenzo please check :)

We use this PR in production since its opening, it works well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant