added support for window.open in onCreateWindow (android)

[zopagaduanjr]

Connection with issue(s)

Resolve issue #1633

related to issue #755

Testing and Review Notes

Currently on Android, onCreateWindow's createWindowAction returns a null url if open.window() function is used.

createWindowAction will only return a non-null url for anchor tags with href specified.

Upon further inspection, it seems that webview's onCreateWindow couldn't retrieve url value if its not an anchor tag.

Hence I've proposed a support for open.window() flow, utilizing its HitTestResult type of unknown type. Aside from the additional logic if type is HitTestResult.UKNOWN_TYPE, this PR also updates the onCreateWindow parameters. isDialog and isUserGesture is made final so that inner class could access it.

Here's a gist to test the behavior of onCreateWindow Url:

https://gist.github.com/zopagaduanjr/b119f5f06d4d3af7bdcbb3b7f99b61ed

Screenshots or Videos

video demo

Screen.Recording.2023-06-01.at.1.48.43.AM.mov

onCreateWindow Urls

To Do

• double check the original issue to confirm it is fully satisfied
• add testing notes and screenshots in PR description to help guide reviewers
• request the "UX" team perform a design review (if/when applicable)

[Vis5]

please approve this PR :)

[littlesmilelove]

This feature is much needed, thanks! @pichillilorenzo

[akhilesh-sharma-GSY]

Please merge this PR if everything is done.