-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add jq as dependency and remove json_extract #4878
Conversation
Example
|
29a8d0a
to
eb7d873
Compare
Signed-off-by: Christian König <ckoenig@posteo.de>
Signed-off-by: Christian König <ckoenig@posteo.de>
Needs re-approval, needed to FP to sign all commits. |
Did you tested this on a raspbian bullseye ? I cannot install it bc apparently the version is not available. https://discourse.pi-hole.net/t/opt-pihole-updatecheck-sh-line-47-jq-command-not-found/57789 |
Yes, all installer dependencies are automatically tested in our test suite: |
@yubiuser Ok, it appears it was linked to raspbian bulleyes repo, If I changed the sources to buster it all went ok. |
What does this PR aim to accomplish?:
Adds
jq
as dependency and removes the now obsoletejson_extract
function.jq
is a small dependency and adds powerfull json abilities. WithFTL v6
we will have a whole new json-based API wherejq
might be needed anyway. Also forPADD
to interact withFTL v6
,jq
will be a requirement: pi-hole/PADD#247By submitting this pull request, I confirm the following:
git rebase
)