Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove port 443 from templates and documentation. #806

Closed
wants to merge 9 commits into from

Conversation

dschaper
Copy link
Member

Description

We don't use 443 inside the container.

Fixes #755

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

From the docs:

> If a repository has any files in its own .github/ISSUE_TEMPLATE folder, including issue templates or a config.yml file, none of the contents of the default .github/ISSUE_TEMPLATE folder will be used.

So we need to copy the config.yml since it will be ignored.
Add required front matter to bug report template.
@dschaper
Copy link
Member Author

Squash please.

@PromoFaux PromoFaux changed the base branch from master to dev February 26, 2021 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove 443 from example yaml/readme and scripts.
2 participants