Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: correct dns upstreams FTLCONF_dns_upstreams variable name #1557

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

shamoon
Copy link

@shamoon shamoon commented Mar 28, 2024

Description

I couldn't figure out why the container wasnt starting because the log output says to use FTLCONF_dns_upstream (missing the s) which was pretty confusing 馃槄, I think its just a typo

Motivation and Context

Error suggests setting an incorrect environment variable

How Has This Been Tested?

This compose fails and gives the output:

Screenshot 2024-03-28 at 11 34 03鈥疉M
  piholev6:
      container_name: piholev6
      image: pihole/pihole:development-v6
      ports:
        - "53:53/tcp"
        - "53:53/udp"
        - "80:80/tcp"
      environment:
        TZ: 'America/Los_Angeles'
        FTLCONF_webserver_api_password: thisisapassword
        FTLCONF_dns_upstream: 8.8.8.8;1.1.1.1
        FTLCONF_dns_listeningMode: all

Verified the variable name at https://ftl.pi-hole.net/development-v6/docs/#get-/config and of course it makes the docker container run

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Signed-off-by: shamoon <4887959+shamoon@users.noreply.github.com>
Copy link
Member

@PromoFaux PromoFaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, my bad, accidentally an s!

@PromoFaux PromoFaux merged commit 4d68ee6 into pi-hole:development-v6 Apr 18, 2024
5 checks passed
@shamoon shamoon deleted the patch-1 branch April 18, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FTLCONF_dns_upstream recommendation not correct in log
3 participants