Update Dockerfile #1552
Merged
Update Dockerfile #1552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er pull FTL from the web, or use a locally built copy. Add a build script for ease of local building (separate from the build-and-test script). Update Readme with build instructions Signed-off-by: Adam Warner <me@adamwarner.co.uk>
dschaper
approved these changes
Mar 25, 2024
|
Just as some info @PromoFaux ^^ |
|
|
Just triggered the V6 image build again and it has succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR aim to accomplish?:
Taking inspiration from docker/cli#1134 (comment), this PR updates the Dockerfile to allow for optional building of the image with a pre-built
pihole-FTLbinary (one must first build FTL locally and copy to thesrcdirectory)Also adds in
build.shto make it easier to build locally, and the Readme has been updated to show it's usage.By submitting this pull request, I confirm the following:
git rebase)