Tidy up a few things in the readme and code.

[PromoFaux]

What does this PR aim to accomplish?:

Dipping my toes back into the water.

• Tidy up a few things in the Readme file
  • Add some more comments to the example compose file
  • Add that setting the container's DNS to be itself is not recommended
• Remove some commended out code from startup script
• Move the webpassword checking section into ensure_basic_configuration
• Ensure that FTL's dns.upstreams config is set (either in environment or config file) hard exit if not.

---

By submitting this pull request, I confirm the following:

1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
2. I have commented my proposed changes within the code and I have tested my changes.
3. I am willing to help maintain this change if there are issues with it later.
4. It is compatible with the EUPL 1.2 license
5. I have squashed any insignificant commits. (git rebase)

---

• I have read the above and my PR is ready for review. Check this box to confirm

[yubiuser]

Test need adjustment.

docker-pi-hole/test/tests/test_bash_functions.py

Line 18 in 2cabcc6

CMD_SETUP_WEB_PASSWORD = ". bash_functions.sh ; setup_web_password"

[PromoFaux]

Test need adjustment.

Ah yes, maybe I will move back to its own function for easier testing.

[rdwebdesign]

This link in the Pi-hole features section is broken.

It is pointing to an old section:

• https://github.com/pi-hole/pi-hole/blob/master/README.md#get-help-or-connect-with-us-on-the-web
  The section "get-help-or-connect-with-us-on-the-web" was removed in 2017.
  The new section is: getting-in-touch-with-us

Also, we should use a link to the repo main page (example: https://github.com/pi-hole/pi-hole#getting-in-touch-with-us), instead of the file contents (https://github.com/pi-hole/pi-hole/blob/master/README.md#getting-in-touch-with-us).

Addressed