Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify build and publish action for v6 #1527

Merged
merged 1 commit into from
Jan 7, 2024

Conversation

PromoFaux
Copy link
Member

@PromoFaux PromoFaux commented Jan 7, 2024

What does this PR aim to accomplish?:

Fix the failing GHA for building and publishing the development-v6 image.

See https://github.com/PromoFaux/docker-pi-hole/actions/runs/7438850620 for proof of it working

https://github.com/users/PromoFaux/packages/container/pihole/164406323?tag=development-v6

https://hub.docker.com/layers/promofaux/pihole/development-v6/images/sha256-2283e5b45624c93d28f402c7cfbe91e0e42b2a90c15bbb79553434faf719de80?context=explore


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

  • I have read the above and my PR is ready for review. Check this box to confirm

@PromoFaux PromoFaux requested a review from a team January 7, 2024 14:38
@yubiuser
Copy link
Member

yubiuser commented Jan 7, 2024

…al matrix for each registry

Remove un-needed action file

Signed-off-by: Adam Warner <me@adamwarner.co.uk>
@PromoFaux PromoFaux merged commit ae7ea35 into development-v6 Jan 7, 2024
7 checks passed
@PromoFaux PromoFaux deleted the v6/fix-actions-finally branch January 7, 2024 21:57
@yubiuser
Copy link
Member

yubiuser commented Jan 7, 2024

Well done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants