Artifacts v4 #1517
Merged
Artifacts v4 #1517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian König <ckoenig@posteo.de>
Signed-off-by: Christian König <ckoenig@posteo.de>
This was referenced Dec 30, 2023
Signed-off-by: Christian König <ckoenig@posteo.de>
PromoFaux
reviewed
Jan 6, 2024
| - name: Prepare name for digest up/download | ||
| run: | | ||
| platform=${{ matrix.platform }} | ||
| echo "PLATFORM_PAIR=${platform//\//-}" >> $GITHUB_ENV |
There was a problem hiding this comment.
does PLATFORM_PAIR get used anywhere?
There was a problem hiding this comment.
Good catch. I forgot to add it.
There was a problem hiding this comment.
Signed-off-by: Christian König <ckoenig@posteo.de>
PromoFaux
approved these changes
Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
artifactsactions to v4 and adjust the workflow account for the breaking changes.P.S. I'm not planing to back-port this to
dev