Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some unnessacery dependencies #1366

Merged
merged 1 commit into from Jul 17, 2023
Merged

Remove some unnessacery dependencies #1366

merged 1 commit into from Jul 17, 2023

Conversation

PromoFaux
Copy link
Member

What does this PR aim to accomplish?:

Partly addresses #1359

By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  • I have read the above and my PR is ready for review. Check this box to confirm

@PromoFaux
Copy link
Member Author

PromoFaux commented Jul 10, 2023 •
edited

Needs: #1367

@PromoFaux
Remove some dependencies, move nano & less to the start script and on…
11b6b8b 
…ly intall if env var `INSTALL_DEV_TOOLS` > 0

Signed-off-by: Adam Warner <me@adamwarner.co.uk>
@sonarcloud
Copy link

sonarcloud bot commented Jul 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@PromoFaux PromoFaux mentioned this pull request Jul 12, 2023
Merged
@PromoFaux
Copy link
Member Author

Just spotted that @DL6ER edited his comment here: pi-hole/docker-base-images#69 (comment)

I think this means that we probably cannot drop libidn & nettle. Clarification needed

DL6ER
DL6ER approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@DL6ER DL6ER left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They can be removed here (Alpine only), they just can't be removed in the installer script as this may be used on Debian-based systems

@PromoFaux
Copy link
Member Author

OK, thanks that's good to know

@PromoFaux PromoFaux merged commit d5b639d into development-v6 Jul 17, 2023
19 checks passed
@PromoFaux PromoFaux deleted the tweak/remove_deps branch July 17, 2023 16:36
@PromoFaux PromoFaux mentioned this pull request Jul 19, 2023
Open
@PromoFaux PromoFaux linked an issue Jul 19, 2023 that may be closed by this pull request
Tidy Up Dependencies #1359
Open
PromoFaux added a commit that referenced this pull request Jul 20, 2023
@PromoFaux
Add ncurses back in for the time being to fix pihole -v output. It …
8cc91c5 
…was removed in #1366.

Signed-off-by: Adam Warner <me@adamwarner.co.uk>
@PromoFaux PromoFaux mentioned this pull request Jul 20, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DL6ER DL6ER DL6ER approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tidy Up Dependencies
2 participants
@PromoFaux @DL6ER