Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Stale workflow #1586

Merged
merged 2 commits into from
Jul 14, 2023
Merged

Fix the Stale workflow #1586

merged 2 commits into from
Jul 14, 2023

Conversation

DL6ER
DL6ER previously approved these changes Jul 12, 2023
@yubiuser
Copy link
Member

Looking at the triggers and the conditionals, I think this is still triggered on schedule.

@PromoFaux
Copy link
Member Author

Ah, yes - you're right. I was conflating two separate issues with the config.

I also noted that it was running against Pull requests, too (which this fixes). I'll rebase on master once #1587 is merged, as that also contains the commit to fix the codespell issue

@yubiuser
Copy link
Member

(which this fixes)

Did you try this? I'm not sure, as we have now

if: github.event_name == 'issue_comment' && ${{ !github.event.issue.pull_request }}

which also contains the part ${{ !github.event.issue.pull_request }} which will be left after your PR. Already the current state should not (but indeed does) trigger on PRs....

@PromoFaux
Copy link
Member Author

I did, but then I deleted the comment. Here, I did it again:

https://github.com/pi-hole/docker-pi-hole/actions/runs/5536224129 - which was triggered by: pi-hole/docker-pi-hole#1366 (comment)

Should fix the conditional

Signed-off-by: Adam Warner <me@adamwarner.co.uk>
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
@PromoFaux PromoFaux merged commit 1a11413 into master Jul 14, 2023
21 checks passed
@PromoFaux PromoFaux deleted the PromoFaux-patch-1 branch July 14, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants