Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting a session successfully returns 204 #379

Merged
merged 3 commits into from
Jan 11, 2024
Merged

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented Jan 7, 2024

Changes the return code for a successful deleted session after the changes made in pi-hole/FTL#1836

Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser yubiuser requested a review from a team January 7, 2024 12:33
Copy link
Member

@DL6ER DL6ER left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't merge yet, only after the referenced FTL PR has been merged

Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser yubiuser requested a review from DL6ER January 7, 2024 20:06
Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser yubiuser merged commit 50f359d into PADD_FTLv6 Jan 11, 2024
5 checks passed
@yubiuser yubiuser deleted the delete_session branch January 11, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants