-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate graphic reports for phys2bids outputs #464
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #464 +/- ##
==========================================
+ Coverage 91.18% 91.75% +0.57%
==========================================
Files 8 9 +1
Lines 1010 1092 +82
==========================================
+ Hits 921 1002 +81
- Misses 89 90 +1
|
@me-pic this is awesome!!! Can you look into the readthedocs failure, please? |
Co-authored-by: Katie Bottenhorn <kbott006@fiu.edu> Co-authored-by: Eneko Uruñuela <e.urunuela@icloud.com> Co-authored-by: Vicente Ferrer <v.ferrer@bcbl.eu> Co-authored-by: Taylor Salo <tsalo006@fiu.edu> Co-authored-by: Stefano Moia <s.moia.research@gmail.com>
for more information, see https://pre-commit.ci
@smoia Not sure exactly what is happening with the doc... Been able to build it locally without any error using sphinx-build. Any hint on what I could check ? |
This reverts commit f5473b5.
f5473b5
to
fd8beab
Compare
No idea - I think it's happening also in #462. It seems to be something about the phys2bids.phys2bids module import? |
@me-pic probably the best option is to update the documentation configuration (as well as sphinx packages version). Maybe we can open a new PR, trying to fit phys2bids docs into nigsp's configuration (it's more recent): https://github.com/MIPLabCH/nigsp/tree/master/docs |
3997ada
to
10ab4ef
Compare
@smoia Thank you ! Will take a look next week. |
Closes #131, #407
The PR solved the issues in #407 with the proposed changes mentioned below.
The PR #407 was itself a follow-up of #243
Proposed Changes
Change Type
bugfix
(+0.0.1)minor
(+0.1.0)major
(+1.0.0)refactoring
(no version update)test
(no version update)infrastructure
(no version update)documentation
(no version update)other
Checklist before review