Micro-optimizations #162
Open
Micro-optimizations #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanTvrdik
reviewed
Nov 14, 2022
| @@ -160,8 +161,10 @@ public function getSkippedHorizontalWhiteSpaceIfAny(): string | |||
| /** @phpstan-impure */ | |||
| public function joinUntil(int ...$tokenType): string | |||
| { | |||
| $tokenTypeMap = array_flip($tokenType); | |||
There was a problem hiding this comment.
is this faster then array_fill_keys($tokenType, true)?
There was a problem hiding this comment.
It's indistinguishable so changing to array_fill_keys() is fine by me :)
JanTvrdik
reviewed
Nov 14, 2022
| $tokens->currentTokenOffset(), | ||
| Lexer::TOKEN_IDENTIFIER | ||
| ); | ||
| $tokensCopy = $tokens->copy(); |
There was a problem hiding this comment.
Can you not just clone $tokens?
There was a problem hiding this comment.
Yes, but I know Ondřej dislikes clone
JanTvrdik
reviewed
Nov 14, 2022
| } | ||
|
|
||
| return new Ast\Type\ConstTypeNode($constExpr); | ||
| } catch (LogicException $e) { | ||
| throw $exception; | ||
| throw $exception(); |
There was a problem hiding this comment.
It looks like constExprParser no longer throws LogicException since d8e9fd9.
|
@rvanvelzen do you have a benchmark or a concrete scenario/code-example where these changes help perf wise? |
ondrejmirtes
force-pushed
the
1.9.x
branch
2 times, most recently
from
d25945f
to
57f6787
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.