[fix_SSH2_class] Introduce a fix for inconsistent return type problem." #1472
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed fix for #1471
I just started replacing all
return false
with exceptions. This is just a proposition. Before I migrate the whole class, I would like some input on this :)There might be some problems with other classes, since there were
private
classes used outside of the scope of the classSSH2
(for example inSCP
), but they might be resolvable by simply introducing real public methods that wrap the private ones, catch the new exceptions and return the old (read: wrong) return types.