Commits for review: Add php Error Reporting Functionality to PMA #1207

JayNakrani · 2014-06-05T16:56:29Z

Add php Error Reporting Functionality to PMA.

…s script is intended to be used same as common.inc.php, but at the end of each script. Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>

… error local & temporary log file. Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>

…file usage. Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>

Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>

…turn first 'X' frames. Send stackhash too. Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>

Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>

…erver URL. Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>

Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>

…r 'false' (user warnings) errors). Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>

JayNakrani · 2014-06-06T03:21:15Z

I'm working on the suggestions of @phpmyadmin-bot. Will push those changes fixing the issues soon.

nijel · 2014-06-06T08:11:56Z

As I've mentioned before requiring common_error_reporting.inc.php in every file is really bad idea. You should instead hook into Footer class, which is already executed at the end of rendering of every page.

nijel · 2014-06-06T08:14:31Z

...I'd probably hook into PMA_Footer::getErrorMessages method.

nijel · 2014-06-06T08:17:30Z

libraries/common_error_reporting.inc.php

+
+	    $_REQUEST['exception_type'] = 'php';
+	    $_REQUEST['send_error_report'] = '1';
+	    require_once('error_report.php');


You should do the error submission asynchronously from the client so that it does not block loading of the page.

nijel · 2014-06-06T08:23:43Z

And last but not least, please rebase your changes on current master to make ti possible to merge your changes.

JayNakrani · 2014-06-06T10:48:21Z

Okay. I will remove the common_error_reporting.php and move that code into a function of PMA_Error_Handler class. That function will be called from PMA_Footer::getErrorMessages().

But should I create a separate branch for that development or is it okay to continue pushing commits on top of this branch?

JayNakrani · 2014-06-06T11:59:09Z

@nijel : I just realized there'd be a problem in putting the common_error_reporting.php code into PMA_Footer::getErrorMessages(). In each request (ajax as well as non-ajax) to PMA there'd be some more code that'll be executed after the call of PMA_Footer::getErrorMessages() and error occurring in that part can not be reported. That problem would not be there if error reporting code is executed at the end of the all script execution. Is PMA_Footer::getErrorMessages() the last thing in each execution? Can you confirm this, please?

nijel · 2014-06-06T12:03:46Z

It's not the last thing being executed, but I don't see a problem with this as the error would be stored in the session and reported with next request.

nijel · 2014-06-06T12:04:23Z

...and you can continue to push commits to this branch.

JayNakrani · 2014-06-06T15:10:29Z

Okay, thanks. I will push the suggested changes shortly.

…reportError()'. Hook it in 'PMA_Footer::getErrorMessages()'. Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>

… from all the scripts. Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>

…') aysnchronous. Stop infinite auto error reporting loop. Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>

Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>

JayNakrani · 2014-06-08T04:09:28Z

@nijel : I've pushed the suggested changes.

Moved the error reporting code from common_error_reporting.php to PMA_Error_Handler::reportError().
Removed common_error_reporting.php file & corresponding inclusions.
Hooked the call to error reporting function in PMA_Footer::getErrorMessages().
Made error reporting asynchronous in the case of sendErrorReport = 'always'.

Please review above commits.

Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>

nijel · 2014-06-09T07:13:12Z

Still the code is not mergeable, so please rebase it on upstream repository. I'll go through the code right now...

nijel · 2014-06-09T07:15:51Z

js/messages.php

+    . '" onclick="PMA_ignorePhpErrors()" style="float: right; margin: 20px;">'
+    . '<input type="submit" value="'
+    . __('Ignore All')
+    . '" onclick="PMA_ignorePhpErrors(false)" style="float: right; margin: 20px;">'


Try to avoid using inline javascript, rather bind it to the class or element id in the javascript code.

JayNakrani · 2014-06-10T17:21:28Z

I've created rebasing in a separate branch. See, Pull#1219.

Closing this one for now.

nijel · 2014-06-11T06:43:19Z

For the next time: You don't have to close the pull request and open new one, it's enough to force pushing branch over existing one.

Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>

JayNakrani added 16 commits May 10, 2014 01:48

Add script that will report all the errors of current-script-run. Thi…

7bdad8e

…s script is intended to be used same as common.inc.php, but at the end of each script. Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>

Include error reporitng script at the end of index.php. Corrosponding…

b137255

… error local & temporary log file. Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>

Add standard pma code for the library files. Add comments explaining …

0cc6c30

…file usage. Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>

Add another parameter to existing js error reporting code.

44ee4d8

Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>

Report errors based on user preference. All the cases taken care of.

74f61dc

Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>

Add appropriate msgs & js functions to handle user actions.

80d86e0

Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>

Fix Syntax errors.

0f46e06

Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>

Make "Ignore All" button work on login page.

e956817

Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>

Remove unnecessary file.

29345e1

Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>

Send only(without HTML) error message string.

0215f1a

Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>

Send only backtrace (not displayBacktrace). Change getBacktrace to re…

d08ef1d

…turn first 'X' frames. Send stackhash too. Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>

Fix failing existing PHPUnit tests.

56ee831

Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>

Remove unnecessary code. A deliberate error & local error-reporting-s…

27bd1f3

…erver URL. Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>

Improve Error Message.

628280b

Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>

Include error reporting script at the end of all the 'relevant' scripts.

c6e582f

Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>

Stop false alarms (displaying prompts-reporting form and reporting fo…

0ec4a2d

…r 'false' (user warnings) errors). Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>

nijel reviewed Jun 6, 2014
View reviewed changes

JayNakrani added 2 commits June 7, 2014 15:31

Move error reporting code to a separate function 'PMA_Error_Handler::…

bef9527

…reportError()'. Hook it in 'PMA_Footer::getErrorMessages()'. Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>

Remove included 'common_error_reporting.php' script and its inclusion…

0491058

… from all the scripts. Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>

JayNakrani added 2 commits June 7, 2014 18:53

Make automatic php error report submission ('sendErrorReport'='always…

d25a83c

…') aysnchronous. Stop infinite auto error reporting loop. Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>

Display appropriate msg while automatically submitting php error report.

8e66074

Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>

Fix coding style issues.

1fd02dc

Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>

nijel reviewed Jun 9, 2014
View reviewed changes

JayNakrani mentioned this pull request Jun 10, 2014

Commits for review: Add php Error Reporting Functionality to PMA (Rebased) #1219

Merged

4 tasks

JayNakrani closed this Jun 10, 2014

JayNakrani deleted the dhananjay-gsoc-dev branch June 16, 2014 17:05

madhuracj added a commit that referenced this pull request Feb 24, 2015

rfe #1207 Export users associated with a specific schema/database

ea0c0ba

Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Commits for review: Add php Error Reporting Functionality to PMA #1207

Commits for review: Add php Error Reporting Functionality to PMA #1207

JayNakrani commented Jun 5, 2014

JayNakrani commented Jun 6, 2014

nijel commented Jun 6, 2014

nijel commented Jun 6, 2014

nijel Jun 6, 2014

nijel commented Jun 6, 2014

JayNakrani commented Jun 6, 2014

JayNakrani commented Jun 6, 2014

nijel commented Jun 6, 2014

nijel commented Jun 6, 2014

JayNakrani commented Jun 6, 2014

JayNakrani commented Jun 8, 2014

nijel commented Jun 9, 2014

nijel Jun 9, 2014

JayNakrani commented Jun 10, 2014

nijel commented Jun 11, 2014

Commits for review: Add php Error Reporting Functionality to PMA #1207

Commits for review: Add php Error Reporting Functionality to PMA #1207

Conversation

JayNakrani commented Jun 5, 2014

JayNakrani commented Jun 6, 2014

nijel commented Jun 6, 2014

nijel commented Jun 6, 2014

nijel Jun 6, 2014

Choose a reason for hiding this comment

nijel commented Jun 6, 2014

JayNakrani commented Jun 6, 2014

JayNakrani commented Jun 6, 2014

nijel commented Jun 6, 2014

nijel commented Jun 6, 2014

JayNakrani commented Jun 6, 2014

JayNakrani commented Jun 8, 2014

nijel commented Jun 9, 2014

nijel Jun 9, 2014

Choose a reason for hiding this comment

JayNakrani commented Jun 10, 2014

nijel commented Jun 11, 2014