Overwrite Rule Properties Without Excluding the Rule

[tis-dm-webfactory]

Add possibility to modify rule properties via config file without defining a completely new rule like this:

<?xml version="1.0" encoding="UTF-8"?>
<ruleset name="pcsg-generated-ruleset"
         xmlns="http://pmd.sf.net/ruleset/1.0.0"
         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
         xsi:schemaLocation="http://pmd.sf.net/ruleset/1.0.0 http://pmd.sf.net/ruleset_xml_schema.xsd"
         xsi:noNamespaceSchemaLocation="http://pmd.sf.net/ruleset_xml_schema.xsd">
    <description>Created with the PHP Coding Standard Generator.
        http://edorian.github.com/php-coding-standard-generator/
    </description>

    <rule ref="rulesets/design.xml" />
    <rule name="CouplingBetweenObjects">
        <properties>
            <property name="maximum" value="20" />
        </properties>
    </rule>
</ruleset>

Fix #39

[kylekatarnls]

Hi thanks, I like this feature a lot. I fixed the PHP 5.3 compatibility in your PR (please pull the change). Could you now add a unit test for that?

And it would be perfect to add a note about this in https://github.com/phpmd/phpmd/blob/master/src/site/rst/documentation/creating-a-ruleset.rst

So other users will know this exists.

[tis-dm-webfactory]

hi Kyle,

yeah sure - I've added two (simple) tests and also wrote a paragraph about how this feature works.
I've pushed it in our repo - if you need another pull request just let me know.

[kylekatarnls]

Very nice!

[MarkVaughn]

Noice

[kylekatarnls]

@ravage84 A last word on this before merging?

[ravage84]

If I understand this PR correctly, it adds the possibility to overwrite the properties of rules without excluding them, once they are added through a rule set, correct?

[tis-dm-webfactory]

@ravage84

If I understand this PR correctly, it adds the possibility to overwrite the properties of rules without excluding them, once they are added through a rule set, correct?

absolutely correct ;-)

[tis-dm-webfactory]

@ravage84
@MarkVaughn
@kylekatarnls
do you need any more changes? there's been no more comments since my last update.

[kylekatarnls]

It's alright for me.

[kylekatarnls]

I fixed the test to make it check what it intended to and sadly it fails (0 instead of 42 in test1 property).

[kylekatarnls]

I checked, It's just a problem with the test. The feature works properly with the example given in the new documentation.

[kylekatarnls]

Test fixed. It was a naming problem: RuleOneInThirdRuleSet instead of RuleOneInFifthRuleSet as it refers to the set3.xml.

[kylekatarnls]

Tests fixed.
https://travis-ci.org/github/phpmd/phpmd/builds/690347990

Fixed

[tvbeek]

@tis-dm-webfactory I'm realizing that this is an old PR. Are you able to rebase it to handle the conflicts and let it run the tests with the GitHub actions?