Add ExceptionList property for LongParameterList #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylekatarnls
previously approved these changes
Jun 25, 2019
ravage84
requested changes
Jun 25, 2019
There was a problem hiding this comment.
@andrewwheal thank you for your enhancement.
Please add some documentation. This way, other's will find this nice enhancement, too.
| @@ -42,6 +42,12 @@ public function apply(AbstractNode $node) | |||
| return; | |||
| } | |||
|
|
|||
| $exceptions = $this->getExceptionsList(); | |||
|
|
|||
There was a problem hiding this comment.
Remove white line to move these two related code parts together. As they belong toghether and do a special thing, they can be extracted into a separate protected method.
For example:
if ($this->parameterIsInExceptionList()) {
return;
}
MarkVaughn
previously approved these changes
Jun 25, 2019
|
@andrewwheal are you still intersted in pursuing this? |
Remove the empty line as requested by @ravage84
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took inspiration/code from the ShortVariable rule which already had an exception list property and added it to the LongParameterList rule.