Use constructor property promotion #1153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.x #1153 +/- ##
============================================
- Coverage 92.30% 92.14% -0.16%
+ Complexity 1286 1278 -8
============================================
Files 111 107 -4
Lines 3444 3375 -69
============================================
- Hits 3179 3110 -69
Misses 265 265 ☔ View full report in Codecov by Sentry. |
AJenbo
force-pushed
the
promote
branch
2 times, most recently
from
a2f8bfc
to
93e27b7
Compare
ravage84
previously approved these changes
May 15, 2024
ravage84
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: refactoring
Breaking change: yes
This also applies some native type hints that are used for the constructors or properties to help simplify things, which is why this is marked as breaking.