Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: refactoring
Breaking change: yes
A good article on the subject: https://ocramius.github.io/blog/when-to-declare-classes-final/
Marks classes we do not extend as final. This makes it easier to reason about both for humans and tools. And it lets us know that they are not changed by users allowing us more flexibility when refactoring, since the internals cannot have been manipulated by an extending class. This also slightly lowers coupling as it promotes using interfaces and abstracts when making hints (10 couplings got removed as part of this PR).
All classes marked as final in this PR either cannot be replaced, should not be extended, or is never used as types.