Move functions to where they are used and mark them private #1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.x #1149 +/- ##
=========================================
Coverage 92.30% 92.30%
Complexity 1286 1286
=========================================
Files 111 111
Lines 3444 3444
=========================================
Hits 3179 3179
Misses 265 265 ☔ View full report in Codecov by Sentry. |
AJenbo
changed the title
ravage84
changed the title
ravage84
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: refactoring
Breaking change: yes
Move 3 functions up the hierarchy to where they are used so they can be marked as private instead of protected.
Makes it easier to reason about both for humans and tools, and we can freely refactor them in the future.