Bump code style to PSR-12 for phpcs #1114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AJenbo
force-pushed
the
psr12
branch
4 times, most recently
from
32407af
to
2ea8b01
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.x #1114 +/- ##
=========================================
Coverage 92.15% 92.15%
Complexity 1278 1278
=========================================
Files 107 107
Lines 3378 3378
=========================================
Hits 3113 3113
Misses 265 265 ☔ View full report in Codecov by Sentry. |
AJenbo
force-pushed
the
psr12
branch
8 times, most recently
from
d6d0425
to
18f5274
Compare
AJenbo
force-pushed
the
psr12
branch
4 times, most recently
from
4823250
to
1425faa
Compare
AJenbo
force-pushed
the
psr12
branch
2 times, most recently
from
2465abf
to
9d3fd98
Compare
AJenbo
force-pushed
the
psr12
branch
4 times, most recently
from
387b0d7
to
6904bdb
Compare
AJenbo
force-pushed
the
psr12
branch
4 times, most recently
from
9c3e89b
to
a7a0cad
Compare
kylekatarnls
approved these changes
May 20, 2024
|
Thanks, glad not to be carrying this one anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: refactoring
Breaking change: no
This configures phpcs to follow the PSR-12 standard which is the basis for PER-CS 2.0 which is our chosen base standard. The disabled rules are part of PSR-12 and so do not need to be explicitly enabled any more.