[Tentative] Create attributes to represent rule properties modifiable by config #1059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylekatarnls
force-pushed
the
feature/auto-seed-properties
branch
2 times, most recently
from
eaaf6a6
to
6a6054b
Compare
kylekatarnls
force-pushed
the
feature/multi-format-support
branch
2 times, most recently
from
0439441
to
7775855
Compare
kylekatarnls
force-pushed
the
feature/auto-seed-properties
branch
from
6a6054b
to
1cee191
Compare
|
Since a fair bit of the changes here are style changes which have already gone in to 3.x I think it would be easier to evaluate and review if it was updated first. |
kylekatarnls
force-pushed
the
feature/multi-format-support
branch
4 times, most recently
from
df1b444
to
2585b4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
Breaking change: yes