Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use common directory structure #1019

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

szepeviktor
Copy link
Contributor

@szepeviktor szepeviktor commented Jul 8, 2023

Type: refactoring
Breaking change: no

  1. Use common directory structure as seen in thousands of PHP packages
  2. Use PSR-4 autoloader (namespace\ = src/)

image

馃ぉ

What do you think about it?
Is it worth to finish?

@szepeviktor szepeviktor changed the title Dir structure Use common directory structure Jul 8, 2023
@AJenbo
Copy link
Member

AJenbo commented Jul 8, 2023

I like the cleaned up structure

@kylekatarnls
Copy link
Member

This will conflict with all our open pull-requests :(

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Jul 8, 2023

@kylekatarnls This is really an inspiration focusing on three root directories: src, tests, website.
Please manage it the way you want.

@AJenbo
Copy link
Member

AJenbo commented Jul 8, 2023

I belive git is actually able to resolve most of that automatically... though maybe not github

@ravage84
Copy link
Member

ravage84 commented May 3, 2024

I think we should look into this once the current dust of changes has settled on the next major version.

Also, I would go one step beyond the "common directory structure as seen in thousands of PHP packages".
We can try to adhere to the directory structure standard of PHP PDS.

@ravage84 ravage84 added this to the 3.0.0 milestone May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants