Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ruleset ref + properties #39

Open
manuelpichler opened this issue Jun 20, 2012 · 3 comments · May be fixed by #664
Open

Support ruleset ref + properties #39

manuelpichler opened this issue Jun 20, 2012 · 3 comments · May be fixed by #664

Comments

@manuelpichler
Copy link
Contributor

Short description

Based on documentation and reading the code, there is no way to include an entire ruleset xml file, while overriding properties of individual rules within that ruleset. That means the only way to override one property of one rule within a ruleset (where you otherwise intend to use all rules within the ruleset) is to refer to every rule in the ruleset independently (using the @ref="rulesets/file.xml/RuleName" syntax). This could be fixed by allowing the (or ) node to have an optional @rule="" attribute, for the sole purpose of override a property for just one rule within the ruleset:

  <rule ref="rulesets/naming.xml">
    <properties>
      <property name="minimum" rule="ShortVariable" value="5" />
    </properties>
  </rule>

Without something like that, the only way to set a single property of a single rule within the ruleset is to explicitly name every rule within the ruleset, and override the property on the one you want. The problem with that is if the built-in ruleset ever changes (e.g., a new rule is added), you would no longer be including that rule, because you are not including the entire ruleset xml file.

Environment

N/A

[Synced from PivotalTracker: 'http://www.pivotaltracker.com/story/show/9355803']

@marcospassos
Copy link

👍

@ravage84
Copy link
Member

ravage84 commented Oct 8, 2014

Probably related to #33

@ravage84 ravage84 modified the milestone: 2.3.3 Nov 7, 2015
@ravage84 ravage84 modified the milestones: 2.3.3, 2.4.2 Mar 8, 2016
@manuelpichler manuelpichler modified the milestones: 2.4.2, 2.4.3 Mar 10, 2016
@ravage84 ravage84 modified the milestones: 2.4.3, 2.4.4 Apr 25, 2016
@kylekatarnls kylekatarnls modified the milestones: 2.7.1, 2.8.1 Oct 19, 2019
@kylekatarnls kylekatarnls added the Good first issue If you want to help, this may be a good start label Oct 19, 2019
@kylekatarnls kylekatarnls modified the milestones: 2.8.1, 2.8.2 Dec 27, 2019
@kylekatarnls kylekatarnls modified the milestones: 2.8.2, 2.8.3 Feb 25, 2020
@kylekatarnls kylekatarnls modified the milestones: 2.8.3, 2.10.0 May 3, 2020
@ravage84 ravage84 modified the milestones: 2.10.0, 2.9.0 May 6, 2020
@ravage84 ravage84 linked a pull request May 6, 2020 that will close this issue
@kylekatarnls kylekatarnls self-assigned this May 23, 2020
@kylekatarnls kylekatarnls removed the Good first issue If you want to help, this may be a good start label May 23, 2020
@tvbeek tvbeek modified the milestones: 2.9.0, 2.10.0 Sep 2, 2020
@kylekatarnls kylekatarnls modified the milestones: 2.10.0, 2.11.0 Apr 11, 2021
@kylekatarnls kylekatarnls modified the milestones: 2.11.0, 2.12.0 Nov 27, 2021
@kylekatarnls kylekatarnls modified the milestones: 2.12.0, 2.13.0 Jun 19, 2022
@kylekatarnls kylekatarnls modified the milestones: 2.13.0, 2.14.0 Sep 10, 2022
@kylekatarnls kylekatarnls modified the milestones: 2.14.0, 2.15.0 Sep 27, 2023
@kylekatarnls kylekatarnls modified the milestones: 2.15.0, 2.16.0 Dec 10, 2023
@ravage84
Copy link
Member

The update from #565 documents the status that is still valid as of today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

5 participants