-
-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ruleset ref + properties #39
Comments
👍 |
Probably related to #33 |
kylekatarnls
added
the
Good first issue
If you want to help, this may be a good start
label
Oct 19, 2019
kylekatarnls
removed
the
Good first issue
If you want to help, this may be a good start
label
May 23, 2020
The update from #565 documents the status that is still valid as of today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Short description
Based on documentation and reading the code, there is no way to include an entire ruleset xml file, while overriding properties of individual rules within that ruleset. That means the only way to override one property of one rule within a ruleset (where you otherwise intend to use all rules within the ruleset) is to refer to every rule in the ruleset independently (using the @ref="rulesets/file.xml/RuleName" syntax). This could be fixed by allowing the (or ) node to have an optional @rule="" attribute, for the sole purpose of override a property for just one rule within the ruleset:
Without something like that, the only way to set a single property of a single rule within the ruleset is to explicitly name every rule within the ruleset, and override the property on the one you want. The problem with that is if the built-in ruleset ever changes (e.g., a new rule is added), you would no longer be including that rule, because you are not including the entire ruleset xml file.
Environment
N/A
[Synced from PivotalTracker: 'http://www.pivotaltracker.com/story/show/9355803']
The text was updated successfully, but these errors were encountered: