Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to htaccess for logo folder to fix FilesMatch conditions #3792

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

myrandor
Copy link

This a a new pull request that use a specific branch and not master so it show only the commit associated with it.

@GaryAllan
Copy link
Collaborator

Hello,
What issue does this fix? If I'm reading the regex correctly <FilesMatch "\.*$"> should only match "." or ".."

@myrandor
Copy link
Author

Hello, What issue does this fix? If I'm reading the regex correctly <FilesMatch "\.*$"> should only match "." or ".."

Better writing on the filematch. Mine disallow everything EXCEPT PNG, which is better than .*$

Also, the original htaccess wouldn't work with Nginx using e404/htaccess-for-nginx because the way filesmatch were processed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants