Display "Locations list" and "Locations map" links for read only users #3755
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, for users with
Read
permission in the moduleLocations
, the Locations map link is not visible because it is inserted (fromapp/tools/menu.php
) only for users withWrite
permission, with this check inapp/tools/all-locations-list.php
:So in this PR I extracted those links from
app/tools/menu.php
and added them to theapp/tools/all-locations-list.php
andapp/tools/all-locations-map.php
files.Hope it makes sense :)