fix: Resolve readline patch attempting to apply to php >7.1 due to OR instead of AND #1357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems that it's related to the #1352. |
|
@peter279k Yes that's related - this would fix that issue |
peter279k
approved these changes
Mar 20, 2024
|
@c9s, could you help me to review this PR? Thanks. |
|
Is there any possibility for this issue to be resolved, it seems that phpbrew is a nice tool that I would like to use on WSL ubuntu but it crashes for this very reason. I found a workaround for anyone searching for a solution try running I don't think I want patches installed by default anyway. |
|
Sorry for the delay. I've merged this PR now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves a patch failure (that interestingly gets ignored) when installing PHP > 7.1
There's an OR so effectively match() always returns true - since it will always either be higher or equal to 5.3 or lower or equal to 7.1