Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure the [LOGO] placeholder works, as well as eg [LOGO:50] #945

Closed
wants to merge 1 commit into from

Conversation

michield
Copy link
Member

Description

Fixed #944

Related Issue

Screenshots (if appropriate):

@michield michield requested a review from bramley April 22, 2023 17:38
@michield
Copy link
Member Author

I don't think this has worked for a long time. Strange it was never found before.

@michield michield requested a review from aulona1 April 22, 2023 17:50
@bramley
Copy link
Contributor

bramley commented Apr 22, 2023

I don't understand this. Using <img src="[LOGO]" /> in a template works for me.

@michield
Copy link
Member Author

Ah, that's a good point. I made it work without the but I'm not sure what the docs say how to use it.

@michield
Copy link
Member Author

Yes, you're right. I thought that [LOGO] would add the image, but you need to put the tags around it. I'll close this, as it will break existing templates that use <img src="[LOGO]" />

It just needs better guidelines I guess.

@michield michield closed this Apr 23, 2023
@michield michield deleted the fix-logo-placeholder branch April 25, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[LOGO] placeholder in campaigns stopped working
2 participants