More php82 fixes #940
Merged
More php82 fixes #940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was branched from https://github.com/bramley/phplist3/tree/php8_deprecations I'll keep this open for a little while to push more things I find |
bramley
approved these changes
Apr 15, 2023
|
Hmm, this PR is getting a bit massive, due to merges and all that. I wonder if we just merge it to the next release branch and do some proper testing instead. |
|
Ah, I changed the target branch to main and it's much better now. |
marianaballa
added a commit
that referenced
this pull request
Aug 18, 2023
This reverts commit daa31c7.
|
This pull request has been mentioned on phpList Discuss. There might be relevant details there: https://discuss.phplist.org/t/3-6-14-release-candidate-ready-for-testing/9109/1 |
|
This pull request has been mentioned on phpList Discuss. There might be relevant details there: https://discuss.phplist.org/t/phplist-3-6-14-released-security-release/9158/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
few more things for PHP8.2
Related Issue
Screenshots (if appropriate):