Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check if the addons plugin is available and use it in preference to t… #939

Closed
wants to merge 1 commit into from

Conversation

michield
Copy link
Member

…he updater.

Description

If the addons plugin is available and enabled, use it as preference over the "updater" and link to it.

Related Issue

Screenshots (if appropriate):

@michield michield requested a review from bramley April 10, 2023 21:00
@michield
Copy link
Member Author

@bramley can you review this? Then we can add it to the next release

@bramley
Copy link
Contributor

bramley commented Apr 23, 2023

I'm not sure about this change.
Firstly whether is a necessary to provide the link for updating, which is in the menu anyway, but also referring directly to a particular plugin. A neater approach is to use the same method as for the editor plugin by identifying whether a plugin implements an interface. That way there isn't a direct reference to a specific plugin.

@michield
Copy link
Member Author

Sure, that would make it more generic and allow other plugins to implement an "updater function". It'll be a fair amount of additional coding to make that construction. I'm worried that the existing updater throws people into maintenance mode without being able to get out of it, so I'd really like to retire the old updater.

Highly unlikely anyone would contribute some additional plugin for updater though, so this would for now be sufficient.

As for the notification here, this will only show when there's an update. The link in the menu is always there, and people wouldn't go and check all the time.

@bramley
Copy link
Contributor

bramley commented Apr 24, 2023

Wasn't so much code after all, see #946

@michield
Copy link
Member Author

superseded by #946

@michield michield closed this Apr 25, 2023
@michield michield deleted the replace-updater-with-addons-plugin branch September 6, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants