[POC] resolving hooks in workpress code #3067
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a POC using the new metadata concept in phpDocumentor to add extra information in your docs. It is far from usefull as many changes are needed in the core code to support this case. This code can be used as reference code to see what we need to change in phpDocumentor and it reveals missing extension points in our application.
This was referenced Nov 13, 2021
Chrico
reviewed
Nov 15, 2021
|
|
||
| final class Action extends AbstractFactory | ||
| { | ||
| private const ACTION_NAMES = [ |
There was a problem hiding this comment.
Actually actions are filters which do nothing return in WordPress. So it's maybe better to call this either Filter or introduce a second class which is called Filter. In WordPress there are following functions which are using internally the Hook API of WP_Hook:
'apply_filters',
'apply_filters_ref_array',
'apply_filters_deprecated',
'do_action',
'do_action_ref_array',
'do_action_deprecated',
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a POC using the new metadata concept in phpDocumentor to add
extra information in your docs. It is far from usefull as many changes are
needed in the core code to support this case.
This code can be used as reference code to see what we need to change in phpDocumentor
and it reveals missing extension points in our application.