Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window API will return Window Rect #804

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

oleg-andreyev
Copy link
Contributor

@oleg-andreyev oleg-andreyev commented Jun 23, 2020

based on specifications Window API, window size manipulation returns window rect, which could be useful for consumers

Ref.:

Because it's an API change, it can only go into the main branch and major version release.

To Do:

  • tests

@williamdes williamdes requested a review from OndraM June 23, 2020 22:14
@oleg-andreyev oleg-andreyev force-pushed the window-api-resuts-window-dimension-object branch from 03d86e3 to f0b65fb Compare June 23, 2020 22:17
@OndraM OndraM added the enhancement New feature label Oct 6, 2020
@OndraM OndraM marked this pull request as draft November 20, 2020 22:44
@OndraM OndraM added this to the 2.0 milestone Nov 20, 2020
@oleg-andreyev oleg-andreyev force-pushed the window-api-resuts-window-dimension-object branch from f0b65fb to 2816cf6 Compare March 14, 2021 15:49
@oleg-andreyev oleg-andreyev marked this pull request as ready for review March 14, 2021 19:25
Copy link
Collaborator

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR adds BC breaks, maybe -> v2

@oleg-andreyev
Copy link
Contributor Author

Yes, I think this was discussed with @OndraM in PR comments

@oleg-andreyev
Copy link
Contributor Author

Yes, I think this was discussed with @OndraM in PR comments

To be exact @OndraM added milestone 2.0

@williamdes
Copy link
Collaborator

Yes, I think this was discussed with @OndraM in PR comments

To be exact @OndraM added milestone 2.0

Sorry, I missed that

Copy link
Collaborator

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@oleg-andreyev oleg-andreyev force-pushed the window-api-resuts-window-dimension-object branch from b670d2a to f37e591 Compare March 20, 2021 22:28
@oleg-andreyev
Copy link
Contributor Author

@OndraM please take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants