Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP 8.3 to CI #855

Closed
wants to merge 1 commit into from
Closed

Add PHP 8.3 to CI #855

wants to merge 1 commit into from

Conversation

dereuromark
Copy link

And it is sufficient to test each min/max of minors, even the min/max of majors usually suffices within PHP.

@mlocati
Copy link
Collaborator

mlocati commented Dec 2, 2023

And it is sufficient to test each min/max of minors, even the min/max of majors usually suffices within PHP.

I'd disagree: it's better to test every single Major.Minor version of PHP.

@dereuromark
Copy link
Author

There is no logical reason in doing so, I can say that with confidence over thousands of repos and years of experience
Only creates more waiting time and burns resources :)
But do what you must.

@dereuromark
Copy link
Author

Your problem here seems to be of different kind anyway.
I will close this then and leave this to the maintainers.

@dereuromark dereuromark closed this Dec 2, 2023
@dereuromark dereuromark deleted the patch-1 branch December 2, 2023 19:55
@mlocati
Copy link
Collaborator

mlocati commented Dec 2, 2023

There is no logical reason in doing so, I can say that with confidence over thousands of repos and years of experience

I can say that 35 years of coding have taught me that it's better to never assume anything 😉

Your problem here seems to be of different kind anyway.

What do you mean?

@dereuromark
Copy link
Author

Well, I still have worked professionally for decades in that specific field :)
Assuming is the thing you do right now

What do you mean?

See failing CI for 8.3

@mlocati
Copy link
Collaborator

mlocati commented Dec 2, 2023

Well, I still have worked professionally for decades in that specific field :)

Me too.

Assuming is the thing you do right now

Yep, both for work (daily) and for a ton of open source projects.

I don't get the reason why you are so malign: you should reconsider the way you approach people you don't know.

@dereuromark
Copy link
Author

There is no malign. I am telling you the facts and logical reason.

I find it rather not helpful to have experts giving you advice and trying to help you keeping this (currently not so well maintained) repo maintained such an answer.
So count me out - good luck moving forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants