New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple Slideshow #931
base: master
Are you sure you want to change the base?
Simple Slideshow #931
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #931 +/- ##
==========================================
+ Coverage 57.34% 57.53% +0.18%
==========================================
Files 196 198 +2
Lines 15607 15738 +131
Branches 533 542 +9
==========================================
+ Hits 8950 9055 +105
- Misses 6408 6434 +26
Partials 249 249
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thanks for your PR. Sounds like a useful feature. I will checkout your changes during the week to review them. |
I like the slideshow feature from the functionality point of view. It will be definitely useful for many users. |
Thanks for your reply. Possible options:
|
Thanks for the explanation and the video attachment with the demo!
I like the idea of having 1 more setting for this.
While the described scenario looks consistent to me, I'd like to read your and @jordy2254 opinions, and probably start some discussion to make sure that we understand all possible use cases and design the workflow in an optimal way) |
This is a simple slideshow feature with a setting for the time interval.
I also admittedly changed the icon placement inside the buttons - this is not necessary, but it made the alignment nicer (in my opinion).
firefox_4th9rIfvZ9.mp4