Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix download path on custom base path #889

Merged
merged 2 commits into from May 20, 2024
Merged

Conversation

djvaldez
Copy link
Contributor

@djvaldez djvaldez commented Sep 3, 2023

This is a fix for the incorrect download URL, along the lines of #838.

@codecov
Copy link

codecov bot commented Sep 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.69%. Comparing base (4133694) to head (7dc3666).

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #889       +/-   ##
===========================================
- Coverage   56.43%   23.69%   -32.74%     
===========================================
  Files         196       96      -100     
  Lines       15601     4406    -11195     
  Branches      558        0      -558     
===========================================
- Hits         8804     1044     -7760     
+ Misses       6543     3114     -3429     
+ Partials      254      248        -6     
Flag Coverage Δ
api 23.69% <ø> (-1.25%) ⬇️
ui ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kkovaletp
Copy link
Contributor

I've merged this PR into #910 - a temporary alternative to the master while the project is on hold, so users still could get the latest Photoview improvements and fixes by building an image locally from this PR code

@jordy2254
Copy link
Member

@djvaldez Can we have this PR rebased against the branch to ensure the test suite runs correctly, the linked PR broke some tests and a fix has been merged I want to be sure that they don't break again.

@kkovaletp
Copy link
Contributor

@jordy2254, as this PR was merged into #910 and all tests are green there, I guess that there is a high probability that they will be green in master after merge too, but if you're not sure, you can git fetch upstream pull/889/head:<new branch name>, rebase it on master, and run tests - I guess that this will be faster than waiting for the response

@kkovaletp kkovaletp added this to In progress in Roadmap via automation Apr 29, 2024
@kkovaletp kkovaletp moved this from In progress to Before next release in Roadmap Apr 29, 2024
@kkovaletp kkovaletp added bug Something isn't working high priority labels Apr 29, 2024
@kkovaletp
Copy link
Contributor

This is another part of a fix for the #834. Mentioning it here for transparency from the issue perspective

@kkovaletp kkovaletp linked an issue May 3, 2024 that may be closed by this pull request
@jordy2254
Copy link
Member

Given @kkovaletp has merged this in the past and checked it I'm happy this is ok and shall merge.

@jordy2254 jordy2254 merged commit 7c7089e into photoview:master May 20, 2024
8 of 9 checks passed
Roadmap automation moved this from Before next release to Done May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high priority
Projects
Development

Successfully merging this pull request may close these issues.

Router doesn't function properly with custom base path
3 participants