New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix download path on custom base path #889
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #889 +/- ##
===========================================
- Coverage 56.43% 23.69% -32.74%
===========================================
Files 196 96 -100
Lines 15601 4406 -11195
Branches 558 0 -558
===========================================
- Hits 8804 1044 -7760
+ Misses 6543 3114 -3429
+ Partials 254 248 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I've merged this PR into #910 - a temporary alternative to the master while the project is on hold, so users still could get the latest Photoview improvements and fixes by building an image locally from this PR code |
@djvaldez Can we have this PR rebased against the branch to ensure the test suite runs correctly, the linked PR broke some tests and a fix has been merged I want to be sure that they don't break again. |
@jordy2254, as this PR was merged into #910 and all tests are green there, I guess that there is a high probability that they will be green in |
This is another part of a fix for the #834. Mentioning it here for transparency from the issue perspective |
Given @kkovaletp has merged this in the past and checked it I'm happy this is ok and shall merge. |
This is a fix for the incorrect download URL, along the lines of #838.