Don't clear results buffer between loops #736
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When tests or suites are looped with TOTAL_LOOP_COUNT or TOTAL_LOOP_TIME, each loop would produce an independent result entry with identical identifiers (descriptions). However, the results viewer and exporters silently ignore any results with duplicate identifiers. This change combines the results from all loops into a single result entry to avoid the issue. Note: This change may cause data loss in existing result files if they have multiple results with the same identifiers. But since those multiple results were never "visible" to users in the first place, it's not a practical issue. Fixes phoronix-test-suite#735
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When tests or suites are looped with TOTAL_LOOP_COUNT or TOTAL_LOOP_TIME, each loop would produce an independent result entry with identical identifiers (descriptions). However, the results viewer and exporters silently ignore any results with duplicate identifiers. This change combines the results from all loops into a single result entry to avoid the issue.
Note: This change may cause data loss in existing result files if they have multiple results with the same identifiers. But since those multiple results were never "visible" to users in the first place, it's not a practical issue.
Fixes #735