Skip to content

Commit

Permalink
pts-core: Additional input sanitization work in the result viewer cod…
Browse files Browse the repository at this point in the history
…e for those using Phoromatic or those changing the default setting for opting for non-local access to the local result viewer
  • Loading branch information
michaellarabel committed Jun 11, 2022
1 parent bae6674 commit bce1fb4
Showing 1 changed file with 12 additions and 1 deletion.
13 changes: 12 additions & 1 deletion pts-core/objects/pts_result_viewer_embed.php
Expand Up @@ -860,6 +860,8 @@ public static function get_html_options_markup(&$result_file, &$request, $public
$si = $sys->get_identifier();
$ppdx = rtrim(base64_encode($si), '=');
$ppd = self::check_request_for_var($request, 'ppd_' . $ppdx);
$ppd = is_numeric($ppd) && $ppd > 0 ? $ppd : 0;

$t .= '
<div id="table-line-' . $ppdx . '" class="div_table_row">';
if($system_count > 1)
Expand Down Expand Up @@ -1225,6 +1227,15 @@ public static function check_request_for_var(&$request, $check)
$ret = str_replace('_DD_', '.', $ret);
}

foreach(pts_strings::safety_strings_to_reject() as $invalid_string)
{
if(stripos($ret, $invalid_string) !== false)
{
echo '<strong>Exited due to invalid input ( ' . $invalid_string . ') attempted:</strong> ' . htmlspecialchars($ret);
exit;
}
}

return $ret;
}
public static function process_request_to_attributes(&$request, &$result_file, &$extra_attributes)
Expand Down Expand Up @@ -1531,7 +1542,7 @@ public static function process_request_to_attributes(&$request, &$result_file, &
}
public static function html_input_field($name, $id, $on_change = null)
{
return '<input type="text" name="' . $name . '" id="' . $id . '" onclick="" value="' . (isset($_REQUEST[$name]) ? strip_tags($_REQUEST[$name]) : null) . '">';
return '<input type="text" name="' . pts_strings::simple($name) . '" id="' . pts_strings::simple($id) . '" onclick="" value="' . (isset($_REQUEST[$name]) ? pts_strings::sanitize(strip_tags($_REQUEST[$name])) : null) . '">';
}
public static function html_select_menu($name, $id, $on_change, $elements, $use_index = true, $other_attributes = array(), $selected = false)
{
Expand Down

0 comments on commit bce1fb4

Please sign in to comment.