Expire static cache on upgrade (#5801)

* Use put instead of put_new * clear cache
phoenixframework · May 3, 2024 · 17eed64 · 17eed64
1 parent ed19338
commit 17eed64
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/lib/phoenix/config.ex b/lib/phoenix/config.ex
@@ -20,8 +20,8 @@ defmodule Phoenix.Config do
   @doc """
   Puts a given key-value pair in config.
   """
-  def put_new(module, key, value) do
-    :ets.insert_new(module, {key, value})
+  def put(module, key, value) do
+    :ets.insert(module, {key, value})
   end
 
   @doc """
@@ -152,6 +152,7 @@ defmodule Phoenix.Config do
         {:stop, :normal, :ok, {module, permanent}}
 
       true ->
+        clear_cache(module)
         {:reply, :ok, {module, permanent}}
     end
   end

diff --git a/lib/phoenix/endpoint/supervisor.ex b/lib/phoenix/endpoint/supervisor.ex
@@ -381,7 +381,7 @@ defmodule Phoenix.Endpoint.Supervisor do
   end
 
   defp warmup_static(endpoint, %{"latest" => latest, "digests" => digests}) do
-    Phoenix.Config.put_new(endpoint, :cache_static_manifest_latest, latest)
+    Phoenix.Config.put(endpoint, :cache_static_manifest_latest, latest)
     with_vsn? = !endpoint.config(:cache_manifest_skip_vsn)
 
     Enum.each(latest, fn {key, _} ->