Fixed #167. Refactor: centralized type handling for simple operations such as add and subtract, and added branch coverage for this #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fferent matrix types (Long/Double/...)
…n FenwickTree.java (#102)
…erent matrix types (Long/Double/...) (#106)
…erent matrix types (Long/Double/...) (#107)
…le matrix types
…er types to Operations.java (#110)
Merge lab4refactoring and lab4tests branches to lab4patch branch
* Fixed #101, feat: added compare function in operations and replaced ugly TODO code with calls to this function in Matrix and SegmentTree
* Fixed #98, tests: added tests for all datatypes (for number representation) to increase branch coverage for TODO functions in SegmentTree
* #Fixed #118, fix: fixed the bug for multiplyUsingLoopWithStringInput so it now can handle zero inputs, also modified the test to cover the case where there are several zeroes ('0000') in the input. Co-authored-by: Magnus Åkerfelt <magnus@akerfeldt.net> Co-authored-by: Beatrice Berg <beab@kth.se>
I have moved those changes to a separate branch, lab4removeForLoops, since it deals with a separate issue
This reverts commit e97d3b7. This commit is reverted since it deals with a separate issue on the main-repo. We will move this commit to a separate branch, so we can make a separate pull request for this specific issue fix.
…-implementation into lab4patch
akerfel
changed the title
akerfel
changed the title
akerfel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created functions which take two
Numberobjects, and either adds, subtracts, or compares them. These Number objects can be of type Integer, Long, Float, Double, BigInteger or BigDecimal. Also added function which does row multiplication forNumberarrays.Instead of using the same code spread over multiple functions, this patch centralizes it to one class (Operations.java), thus decreasing code repetition and cylcomatic complexity, while increasing readability.
Also added branch coverage for these different Number types, since it was missing (previous tests only tested relevant functions using Integers).
For more details, see issue #167.
By submitting this pull request I confirm I've read and complied with the below requirements.
Added {Algorithm/DS name} [{Language}], notUpdate README.mdorAdded new code.