Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: added tests to several methods to increase branch coverage #166

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

tests: added tests to several methods to increase branch coverage #166

wants to merge 15 commits into from

Conversation

Snebie
Copy link

@Snebie Snebie commented Feb 25, 2022

Added the tests to a few methods to increase branch coverage. In the process we discovered a bug which is described in issue #165.

By submitting this pull request I confirm I've read and complied with the below requirements.

  • I have read the Contribution guidelines and I am confident that my PR reflects them.
  • I have followed the coding guidelines for this project.
  • My code follows the skeleton code structure.
  • This pull request has a descriptive title. For example, Added {Algorithm/DS name} [{Language}], not Update README.md or Added new code.

Snebie and others added 15 commits February 23, 2022 17:27
@Snebie
Fixed #16, test: modified existing test to also include the case wher…
b8867f0 
…e number is 0 (#34)
@Snebie
Fixed #15, test: Added test for when numerator is greater than denomi…
1c94212 
…nator, which covers another branch not included in existing tests (#36)
@Snebie
Fixed #13, test: Added tests for increased branch coverage (#35)
4349082 
* Relating to #13, test: added test for multiplicationUsingFFT where input is zero

* Fixed #13, test: added test for multiplicationUsingLoopWithStringInput where input is zero, also added requirements comments
@reversedpeach
Fixed #40. test: Added testKruskalNull to test branch
a908479
@reversedpeach
Merge pull request #45 from DD2480-group11/issue/40
d0b6c3b 
Fixed #40. test: Added testKruskalNull to test branch
@reversedpeach
Fixed #41. tests: Added testKruskalDirected to tests branch
d4abe7f
@reversedpeach
Merge pull request #46 from DD2480-group11/issue/41
2937689 
Fixed #41. tests: Added testKruskalDirected to tests branch
@reversedpeach
Fixed #38. test: Added testBellmanFordNull to tests branch (#47)
8ceded8
@reversedpeach
Fixed #39. test: Added testFloydWarshallNull to tests branch (#48)
0851191
@akerfel
Fixed #51. fix: Commented out test which fails (it highlights a bug) (#…
6f515c3 
…52)
@akerfel
Fixed #56. test: Added branch coverage for List.grow. (#58)
322bc7e 
Specifically, made sure that the grow() function is called correctly from the ArrayList implementation of List. This should happen when the underlying array is not large enough to store all elements.
@akerfel
Fixed #59. Added branch coverage for List.remove. (#60)
c822e9b 
Requirement: If someone tries to remove an element at a negative (i.e. invalid) index in an ArrayList, then null should be returned.
@akerfel
Fixed #61. test: Added branch coverage for List.shrink to tests branch.
3d3c998 
Tests that the private function shrink() in the ArrayList implementation
in the file List.java works correctly.
Requirement: If the size attribute becomes smaller than half the size of the underlying array,
then the shrink() function should be called, which should decrease the size of said array.
@akerfel
Fixed #62. test: Added branch coverage for List.validate to tests bra…
38a9bc5 
…nch. (#63)

Asserted the following requirement:
The validate() function should return false for lists with null elements.
@akerfel
Fixed #64. Put related tests next to each other. (#65)
fab0bfb 
Specifically: put testRemoveInvalidIndex after testShrinkArrayList
@akerfel akerfel deleted the tests branch March 1, 2022 23:16
@akerfel akerfel restored the tests branch March 1, 2022 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Snebie @reversedpeach @akerfel