Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chromadb implementation w.i.p #196

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

chromadb implementation w.i.p #196

wants to merge 4 commits into from

Conversation

hoxsec
Copy link

@hoxsec hoxsec commented Apr 28, 2024

new file:   phi/vectordb/chromadb/chromadb.py

@Hk669
Copy link

Hk669 commented Apr 29, 2024

can we collaborate on this? @hoxsec

@hoxsec
Copy link
Author

hoxsec commented Apr 29, 2024

can we collaborate on this? @hoxsec

Ofcourse, go ahead.

@Hk669
Copy link

Hk669 commented Apr 29, 2024

can you share me information on what you are working on actually?

@hoxsec hoxsec changed the title new file: phi/vectordb/chromadb/__init__,py chromadb implementation w.i.p Apr 29, 2024
@hoxsec
Copy link
Author

hoxsec commented Apr 29, 2024

Problem Description

I encountered an error related to type hinting with the chromadb.Client in a property decorator. The error message was:

error: Function "chromadb.Client" is not valid as a type [valid-type]

This issue prevented the mypy unit tests from passing, as the type hint was not recognized properly.

Do you have a solution?

@Hk669
Copy link

Hk669 commented Apr 30, 2024

that's because you are returning the chromadb.Client() , instead create a new type for the chromadb.Client().

chromaClient = Type[chromaeb.Client()]

this should work. @hoxsec

@ashpreetbedi
Copy link
Contributor

Thanks for this @Hk669 and @hoxsec, happy to review when ready :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants