Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow parent of dropdown be a real link #1155

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow parent of dropdown be a real link #1155

wants to merge 1 commit into from

Conversation

auipga
Copy link
Contributor

@auipga auipga commented Feb 8, 2016

When changing the behaviour of the menu (eg. open on hover), it should be allowed for the parent of a dropdown to have a URI instead of forcing to href="#"

Example: (--> About)
http://vadikom.github.io/smartmenus/src/demo/index.html

When changing the behaviour of the menu (eg. open on hover), it should be allowed for the parent of a dropdown to have a URI instead of forcing to `href="#"`

Example: (--> About)
http://vadikom.github.io/smartmenus/src/demo/index.html
@phiamo
Copy link
Owner

phiamo commented Feb 3, 2017

@auipga how does this behave if you dont set an uri ?

@auipga
Copy link
Contributor Author

auipga commented Mar 7, 2017

@phiamo if no URI is set, it uses the original # as fallback

#1035 is not connected with my issue but should also be applied (uri = javascript:;) as this change is a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants