Optionally recursive $geometry->getComponents #74
Conversation
…eaking down a geometry to speficied types.
|
This needs some things fixed still. It seems odd to check if parameters are included on every function call including recursive calls, so the recursive portion of the function could be separated into a private function called if parameters are included. The base case should check if the current geometry is of one of the specified types rather than immediately breaking it down into sub components and looping. In case no valid geometry types are provided the Point type should be added to the types array regardless of intention to prevent possible accidental infinite recursion. |
- Split recursive functionality into a private method. - Changed structure of recusive calls to avoid calling getComponents on points.
|
The last commit should address issues I brought up in the last comment. I don't imagine this is an important feature, but since I have needed this behaviour a number of times and have always ended up writing a function to retrieve points lines and polygons from a geometry it seemed like something that has no reason not to be included in geoPHP to start with. |
Altered getComponents so that it behaves in the normal manner if no parameters are provided, but has the option of specifying a geometry type or an array of geometry types and then recursively break down the geometry until all components comprise of the types provided.
The use case this is intended for is primarily to break down a complex geometry collection into points, lines, and polygons with a single function call.
ie:
$geometry->getComponents(array('Point', 'LineString', 'Polygon'));