Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clearing debugger subscriptions and subcomponents in StDebuggerExtensionMechanismTest>>#tearDown #712

Conversation

adri09070
Copy link
Contributor

Fixes #666

This PR clears debuggers that were not cleared correctly in StDebuggerExtensionMechanismTest:

  • They were not unsubscribed from SystemAnnouncer
  • They were not unsubscribed from their action model
  • Their debug session was not cleared
  • Their action model was not cleared

This could cause #666 in the tearDown when reactivating extensions that were activated before running the tests

@estebanlm
Copy link
Member

it is ok for me but let's wait until we fix current unstabilities

@adri09070 adri09070 added bug Something isn't working debugger labels Apr 15, 2024
@adri09070 adri09070 closed this Apr 18, 2024
@adri09070 adri09070 reopened this Apr 18, 2024
Copy link
Member

@StevenCostiou StevenCostiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in tests.
Seem good.

@StevenCostiou StevenCostiou merged commit 0abadf6 into pharo-spec:Pharo12 May 3, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working debugger
Projects
None yet
3 participants